galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Refactor Workflow API routes - Part 2

Open heisner-tillman opened this issue 2 years ago • 5 comments

This is a part of #10889 and an extension of #17463.

Summary

  • Refactored API routes:
    • [x] PUT: /api/workflows/menu

      • [x] Added pydantic models to input
      • [x] Added pydantic models to return
      • [x] Removed the mapping to the legacy route
      • [x] Write appropriate tests
    • [x] GET: /api/workflows/download/{workflow_id}, /api/workflows/{workflow_id}/download

      • [x] Added pydantic models to input
      • [x] Added pydantic models to return
      • [x] Removed the mapping to the legacy routes

How to test the changes?

  • [x] This is a refactoring of components with existing test coverage.
  • [x] Instructions for manual testing are as follows: You can find the interactive API documentation here: http://127.0.0.1:8080/api/docs#/workflows Screenshot 2024-03-29 at 16-03-07 Galaxy API - Swagger UI

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

heisner-tillman avatar Feb 26 '24 18:02 heisner-tillman

This is not ready for review. I just wanted to create this pull request such that there is no duplication effort

heisner-tillman avatar Feb 26 '24 18:02 heisner-tillman

This is not ready for review. I just wanted to create this pull request such that there is no duplication effort

Converting to draft.

jdavcs avatar Feb 26 '24 19:02 jdavcs

Test failures seem relevant

davelopez avatar Apr 02 '24 08:04 davelopez

Test failures seem relevant

I rebased on dev and they disappeared. Are you sure?

heisner-tillman avatar Apr 02 '24 17:04 heisner-tillman

Was something related to workflow API, but I didn't dig much. Glad they werent related though :)

davelopez avatar Apr 02 '24 18:04 davelopez