galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Add element_identifier and ext to inputs config file export

Open bernt-matthias opened this issue 1 year ago • 1 comments

element identifiers are crucial for collections and need to be exposed in the inputs configfile export. it's too hacky to parse the identifier from the staging path (plus: the staging path is sanitised).

I suggest to make the element_identifier a list, because it is for collections (there the first list elements are collection identifiers and the last the element identifier of the dataset), such that users (tool developers) do not need to check if it is a list or a string.

TODO:

  • [x] docs in xsd

How to test the changes?

(Select all options that apply)

  • [x] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

bernt-matthias avatar Jan 25 '24 17:01 bernt-matthias

This seems great!

jmchilton avatar Jan 25 '24 17:01 jmchilton

Thank you, @bernt-matthias!

jdavcs avatar Mar 01 '24 15:03 jdavcs

This PR was merged without a "kind/" label, please correct.

github-actions[bot] avatar Mar 01 '24 15:03 github-actions[bot]