galaxy
galaxy copied to clipboard
Add History Multiview activity+panel, add "Show Recent" mode to multiview
Added a History Multiview activity and side panel, which can be used to select histories in Multiview.
This also adds the option of showing 4 latest histories in History multi view, instead of always tracking pinned histories. Once the user decides to track pinned histories, we do so, until the user "resets" it to recent histories mode.
Also organized the multiple histories in Multiview to show up evenly, with the HistoryDetails taking up a fixed space at the top.
Fixes https://github.com/galaxyproject/galaxy/issues/17143 Closes https://github.com/galaxyproject/galaxy/pull/16001 (every item when mounted, is loaded here)
https://github.com/galaxyproject/galaxy/assets/78516064/3d5c3609-7e96-4c22-bd7a-25c9bbeb50aa
A singular Histories activity and panel?
This also opens up the potential of a singular Histories activity+side panel which - instead of changing route to the histories list (as the histories activity currently does) - toggles out a Histories side panel, and this panel contains:
- A searchable History list (similar to the one in this Multiview panel) used to select the current history for the
HistoryPanel(and other AdditionalOptions) by default - A button group used to either:
- Open Histories list in center panel (side panel remains the same)
- or, Open Multiview in center panel; then the History scroll list in side panel changes into the version from the Multiview panel, used to select histories for Multiview
Idea for https://github.com/galaxyproject/galaxy/issues/17284 ?
How to test the changes?
(Select all options that apply)
- [x] I've included appropriate automated tests.
- [x] This is a refactoring of components with existing test coverage.
- [ ] Instructions for manual testing are as follows:
- [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]
License
- [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.
This is a huge improvement, I like it a lot. I am skeptical that merging this with the regular histories activity will be an improvement ?
A separate Histories activity side panel
https://github.com/galaxyproject/galaxy/assets/78516064/b7155e95-08d4-49aa-bd3c-3345162eac08
This is separate from the History Multiview activity panel, and it can be used to quick operations on histories (like setting current, opening in center panel etc) and clicking on the Histories activity will not change user's route. To see all Histories in the center grid, the user can click on All histories in the footer (just like in the NotificationsPanel).
This can be tested here: https://github.com/ahmedhamidawan/galaxy/tree/histories_side_panel
A Singular Histories activity and side panel
https://github.com/galaxyproject/galaxy/assets/78516064/6a6a9595-1c8b-43b6-b445-d3a0d10fc0a7
This is an example of a singular Histories activity and side panel (removes the multiview activity). It is a consolidation of the Histories and History Multiview side panel, and by default, it has the Histories side panel (from the example above). At the bottom, it has a button group which allows routing to either the Histories grid list or the multiview. When on the multiview route, the side panel switches to the multiview selector version, and on any other route it has the default, current history selector version.
This can be tested here: https://github.com/ahmedhamidawan/galaxy/tree/singular_histories_side_panel
Split Activity Buttons (panel and route both in one activity)
https://github.com/galaxyproject/galaxy/assets/78516064/ef7e4922-770b-4d41-89dc-b58c7299d487
This way the user can quickly open the History Grid or open the Histories panel
Implemented on top of https://github.com/ahmedhamidawan/galaxy/tree/histories_side_panel
Failing Toolshed tests seem unrelated...