galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Add input datatype as an Advanced Tool Search filter

Open ahmedhamidawan opened this issue 2 years ago • 4 comments

Fixes #16437 Users are able to search for tools that take in certain datatypes

https://github.com/galaxyproject/galaxy/assets/78516064/07d2d14d-dc11-4b75-8bf1-e04f5f8c61f2

How to test the changes?

(Select all options that apply)

  • [x] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

ahmedhamidawan avatar Aug 15 '23 21:08 ahmedhamidawan

I don't think it works the way users would expect it to work, since it doesn't take into account the subclass hierarchy. If you got a fastq file it will for instance not return tools that process txt files, and I don't think it's a smart idea to expand to all subclasses for every input; that would be a whole lot of data.

I would maybe think about a smart way to index the toolbox by accepted inputs and bypass the whoosh search, which I think is too static for this type of problem.

mvdbeek avatar Aug 24 '23 10:08 mvdbeek

I'm not sure the subclass matching is a great idea - if I searched for fastq tools and it showed me lots of generic txt input tools I I'd think search is broken?

neoformit avatar Aug 24 '23 21:08 neoformit

Say you want the first 10 entries from your fasta file, or you want to convert it to fastq.gz, or you have fastq and the tool consumes fastqsanger. Whoosh search is just not the right thing for this problem, apart from the other reasons I listed above. We should not do this.

mvdbeek avatar Aug 25 '23 10:08 mvdbeek

fyi: @ahmedhamidawan bumping this to 24.1

jdavcs avatar Feb 26 '24 20:02 jdavcs