galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

One or two fixes to timeouts

Open bernt-matthias opened this issue 1 year ago • 0 comments

  1. do not wait 2x in tool tests
  2. do not use accumulated sleep times but time difference

Not sure if the 2nd is good or possible. If not we should change the planemo CLI docs for the --test_timeout parameter.

Edit:

OK I see sleep_ is used in testing and also accumulated test times maybe easier to test. So I'm happy to revert https://github.com/galaxyproject/galaxy/pull/14667/commits/cdf7187f583880159aec14da2de59be3c95ade20 .. but I will wait for feedback.

Maybe increasing delta a bit will make --test_timeout be closer to what the planemo user observes.

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [x] This is a refactoring of components with existing test coverage I hope / assume
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

bernt-matthias avatar Sep 21 '22 13:09 bernt-matthias