galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

History drag and drop

Open itisAliRH opened this issue 2 years ago • 1 comments

Related #14600: Drag and drop to a collection or dataset to copy between histories

https://user-images.githubusercontent.com/2105447/191347272-d19f21ae-97e8-4172-8aa8-cb542d7c4a93.mov

  • [x] Drag and drop between histories
  • [x] Drop zone

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [x] Instructions for manual testing are as follows:
    1. go to histories multiple view
    2. drag a collection or dataset and drop on another history to copy

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

itisAliRH avatar Sep 19 '22 17:09 itisAliRH

@itisAliRH can you please try to add a dynamic text to the drop-target? Something like "Copy X files into history xyz" or "Copy one collection with X elements to xyz" at least if we have this information already, it would be nice to show it.

bgruening avatar Sep 20 '22 21:09 bgruening

@itisAliRH can you please try to add a dynamic text to the drop-target? Something like "Copy X files into history xyz" or "Copy one collection with X elements to xyz" at least if we have this information already, it would be nice to show it.

this can also come in a follow-up imho

bgruening avatar Sep 22 '22 13:09 bgruening

That one looks good to me! @guerler @dannon any concerns?

bgruening avatar Sep 23 '22 12:09 bgruening

This PR was merged without a "kind/" label, please correct.

github-actions[bot] avatar Sep 23 '22 12:09 github-actions[bot]