[22.05] linter: allow options elements in data params

[bernt-matthias]

Linting of valid childs for params has been added here: https://github.com/galaxyproject/galaxy/pull/12232, but options for data params has been forgotten.

In addition also checks for valid attribs and filter types has been added to linting.

Questions:

• [ ] why are tools like tools/maf/interval2maf.xml not linted by the CI?

TODO

• options_filter_attribute seems allowed
• [x] check if this is still true https://github.com/galaxyproject/galaxy/blob/a5c2eb839bc87b9a67537efce9f1434af94520f9/lib/galaxy/tools/parameters/basic.py#L1843 .. example (interval2maf suggests that also other metadata works)
• [x] maybe doc better alternative https://github.com/galaxyproject/galaxy/blob/a5c2eb839bc87b9a67537efce9f1434af94520f9/test/functional/tools/validation_metadata_in_range.xml#L7
  • seems that filtering for a fixed set of metadata values is possible as well with a validator
  • but filtering for a metadata value of another input parameter is not at the moment .. maybe we should extend the validator in this respect?

How to test the changes?

(Select all options that apply)

• [x] I've included appropriate automated tests.
• [ ] This is a refactoring of components with existing test coverage.
• [ ] Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• [x] I agree to license these contributions under Galaxy's current license.
• [x] I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].