galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Fix type annotation of assert functions

Open bernt-matthias opened this issue 2 years ago • 0 comments

asserts: n, delta, min, max need to be str since the allow extensions: (K|M|G|T|P|E)i

solved by automatically converting bools, integers, and suffixed integers before calling the assertion functions.

follow up on https://github.com/galaxyproject/galaxy/pull/12528

I guess this should wait for the refactoring of the tests that is currently ongoing in https://github.com/galaxyproject/galaxy/pull/13186

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these contributions under Galaxy's current license.
  • [x] I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

bernt-matthias avatar Jan 26 '22 11:01 bernt-matthias