galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

linter: warn if expect_num_outputs is missing

Open bernt-matthias opened this issue 3 years ago • 1 comments

if outputs have filters or are discovered

How to test the changes?

(Select all options that apply)

  • [x] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these contributions under Galaxy's current license.
  • [x] I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

bernt-matthias avatar Nov 24 '21 10:11 bernt-matthias

Can you push this into a profile version ? I don't think this should be a warning for old tools.

Hrmm. This change should not affect the functionality of tools, but just the linter. Which is as far as I see only called from planemo... imho the linter should always output according to the latest standards which allows tools to slowly catch up (always if they are touched).

bernt-matthias avatar Dec 21 '21 09:12 bernt-matthias

@bernt-matthias If ready for review, please remove the status/WIP label.

nsoranzo avatar Sep 16 '22 00:09 nsoranzo