galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

dynamic options: add data table filter

Open bernt-matthias opened this issue 3 years ago • 2 comments

In a recent gitter discussion (https://gitter.im/galaxy-iuc/iuc?at=6190aeff8c019f0d0b93414b) it was asked for a way to have a select list containing only elements that are not yet in a data table.. Et voila .. there is a data table filter.

The test tool shows how it might be used:

  1. the options are dynamically create from a file (from_file also had no test so far)
  2. the filter removes all options that are already in the data table

For the first part I needed to apply a little hack: from_file seems to assume that the file is in tool-data in the Galaxy root. It would be much nicer if the file would be loaded from the dir (or a tool-data dir in this dir) containing the tool. Otherwise we would not meet the use case of the gitter discussion.

I did not think about other possible use cases (e.g. intersections of data tables) and possibly needed attributes...

Ping @mvdbeek @pvanheus

The PR also adds more linting to filters.

How to test the changes?

(Select all options that apply)

  • [x] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these contributions under Galaxy's current license.
  • [x] I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

bernt-matthias avatar Nov 17 '21 20:11 bernt-matthias

I'm bumping this to 22.05, we still need to figure out what's up with https://github.com/galaxyproject/galaxy/pull/12941#discussion_r772962524

mvdbeek avatar Jan 26 '22 11:01 mvdbeek

There's a conflict here and I think the framework test failure is legitimate ?

mvdbeek avatar Jun 21 '23 18:06 mvdbeek