galaxy
galaxy copied to clipboard
Add framework test using unuploadable test data
Datatypes can be either visible in uploads or not (display_in_upload="true|false"
). There are good reasons to to keep this distinction:
- some datatypes exist "only" to ensure that correct inputs are used
- do not clutter the upload form with such data sets
But there are also reasons against it:
- sharing of datasets across Galaxys (but there is the slightly inconvenient detour via
Edit dataset attributes
)
The problem is that its currently impossible to test tools (with planemo) that have inputs with datatypes that have display_in_upload="false"
.
- [x] add test to show problem
- [ ] fix
This becomes really important if https://github.com/galaxyproject/galaxy/pull/12073 would be merged. Because it will forbid to give arbitrary dataypes to data parameters (which allowed to specify/use a datatype which is an uploadable superclass ).
How to test the changes?
(Select all options that apply)
- [x] I've included appropriate automated tests.
- [ ] This is a refactoring of components with existing test coverage.
- [ ] Instructions for manual testing are as follows:
- [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]
License
- [x] I agree to license these contributions under Galaxy's current license.
- [x] I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].
I approve of this but I think we should clarify and formalize why we hide datatypes from upload. Just to declutter it seems like a mistake - it is cluttered, we can't unwind that be excluding iqtree. Even if we want that, if there are security issues with uploading a particular datatype - we should mark that and make sure we have tests that verify data fetch and random import tools do not allow these datatypes to be ingested.