galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Comment processing for Add Column tool

Open selten opened this issue 4 years ago • 1 comments

Comment processing for Add Column tool

As described in #10772 the Add Column tool included with Galaxy added columns where there were comments, this could cause problems in downstream analyses. This update will retain the comments instead.

selten avatar Nov 24 '20 13:11 selten

diff --git a/lib/galaxy_test/base/data/test_workflow_batch.ga b/lib/galaxy_test/base/data/
index 32de906b38..8a4792542f 100644
--- a/lib/galaxy_test/base/data/test_workflow_batch.ga
+++ b/lib/galaxy_test/base/data/test_workflow_batch.ga
@@ -57,7 +57,7 @@
             "tool_errors": null,
             "tool_id": "addValue",
             "tool_state": "{\"__page__\": 0, \"__rerun_remap_job_id__\": null, \"__job_re
-            "tool_version": "1.0.0",
+            "tool_version": "1.0.1",
             "type": "tool",
             "uuid": "1daceb2a-719c-49a6-881c-5301076de918",
             "workflow_outputs": []

Those test failures look legitimate - can you make this change and see if it helps?

jmchilton avatar Nov 24 '20 15:11 jmchilton

I switched this to draft, please feel free to follow up

martenson avatar Jun 27 '23 02:06 martenson