ansible-galaxy
ansible-galaxy copied to clipboard
Ancillary config files are incorrectly configured by default
The changes to how job metrics, dependency resolvers and container resolvers are configured introduced by https://github.com/galaxyproject/ansible-galaxy/pull/133 result in incorrect config in the default case.
What I mean by that is that if, for example, I do not set the galaxy_job_metrics_plugins variable, I get a line in my galaxy.yml like:
job_metrics_config_file: /galaxy_dir/config/job_metrics.conf.xml
and then /galaxy_dir/config/job_metrics.conf.xml is non-existent with the result that Galaxy will now start up with no job metrics config whatsoever, possibly triggering this bug: https://github.com/galaxyproject/galaxy/issues/14557
Also worth noting that Galaxy in its default configuration would load the core plugin, and this I believe prevents that.
Also worth noting that Galaxy in its default configuration would load the
coreplugin, and this I believe prevents that.
Exactly. So the behaviour that is wanted is that:
- if the user sets
galaxy_job_metrics_pluginsa yaml file is generated with the appropriate configuration. - if the user sets
job_metrics_config_filein theirgalaxy_configthen that value is respected (I think that this should already be the case because the issue noted above impacts the Ansible defaults. - if the user sets neither, the
job_metrics_config_fileis either not set (preferable) or points to a sample config that maintains the Galaxy default behaviour. I'm not sure how to do this in Ansible - one might need conditionally set config variables that get merged into a final set of defaults.