Piotr Galar

Results 145 comments of Piotr Galar

> As we discussed in our call, let's merge this and implement any improvements to the reporter in follow-up PRs. > > re the missing test cases: if you want...

The placeholders for the new sample projects were created as part of https://github.com/NomicFoundation/hardhat/pull/5774. We'll need to update and expand them as we implement necessary plugins.

@antico5 I did a little exploration on forcing the colors for the tests and trying to disable them from within the reporter - https://github.com/NomicFoundation/hardhat/pull/6769

Nice! Let's just add `process.env.FORCE_COLOR = 1` before https://github.com/NomicFoundation/hardhat/blob/v-next/v-next/hardhat-node-test-reporter/integration-tests/index.ts#L85. That way we'll see whether the colors are correctlys tripped in CI.

> Hi [@galargh](https://github.com/galargh) as [@sukunrt](https://github.com/sukunrt) mentioned, v0.42.0 is released but it's not marked as `latest` https://github.com/libp2p/go-libp2p/releases/tag/v0.41.1 still has the `latest` tag > > I marked 42 as latest manually but...

This is replaced by https://github.com/NomicFoundation/hardhat/pull/6928

We certainly can, this would serve as a replacement for https://github.com/ipfs/service-worker-gateway/blob/main/.github/workflows/main.yml Let me know what you think and I could work on making the workflow being added here 🟢

With https://github.com/NomicFoundation/edr/pull/705 in place, we could get away with being less strict when it comes to test contracts discovery. It still could be useful if, let's say, we wanted to...

Agreed, that's exactly what I discovered when playing around with compilation for the test task. I'm going to share my thoughts on that later today in a doc.

> Why do we remove need/very-expensive-tests? I assume because this is the way to manually trigger the expensive test run for the PR. > > I guess in a perfect...