HydraDX-node icon indicating copy to clipboard operation
HydraDX-node copied to clipboard
verified publisher icon galacticcouncil

fix: disable ED charging and refund for insufficient assets

Open dmoka opened this issue 1 year ago • 2 comments

Solves this: https://github.com/galacticcouncil/HydraDX-node/issues/820

  • [x] rebenchmark router, update behchmark, then rebenchmark DCA with new weights
  • [ ] @mrq1911 find out the the XCM issue that where we should also not charge ED
  • [ ] considering moving the SkipEd storage to asset registry to have a more generic solution
  • [ ] rebenchmark router and orml-tokens once everything resolved

dmoka avatar Jun 03 '24 13:06 dmoka

Crate versions that have been updated:

  • runtime-integration-tests: v1.23.1 -> v1.23.2
  • pallet-route-executor: v2.5.0 -> v2.5.1
  • hydradx-runtime: v255.0.0 -> v256.0.0

Runtime version has been increased.

github-actions[bot] avatar Jun 03 '24 13:06 github-actions[bot]

orml-tokens needs be rebenchmarked also, you introduced new storage ops into each transfer

martinfridrich avatar Jun 10 '24 09:06 martinfridrich

orml-tokens needs be rebenchmarked also, you introduced new storage ops into each transfer

done!

dmoka avatar Jul 24 '24 06:07 dmoka