HydraDX-node icon indicating copy to clipboard operation
HydraDX-node copied to clipboard

Build version based only on assets in source code

Open mrq1911 opened this issue 3 years ago • 1 comments

Currently, version is grabbed from the last tag in the git tree, this, however, doesn't work if you don't build from git repo, or you just pulled a shallow branch.

There are multiple ways how to solve it:

  • metadata in node/Cargo.toml
  • parse changelog
  • add a file with this information

also if the source is not built from git repo, revision hash shouldn't be present I the version string

mrq1911 avatar Apr 20 '21 15:04 mrq1911

I'd go with changelog as we already do that and everything else is more maintenance work.

jak-pan avatar Apr 20 '21 15:04 jak-pan