Basilisk-node icon indicating copy to clipboard operation
Basilisk-node copied to clipboard

feat!: [WIP] Integrate EMA Oracle

Open apopiak opened this issue 3 years ago • 2 comments

Integrate the EMA oracle from https://github.com/galacticcouncil/warehouse/pull/76 into the Basilisk runtime.

Description

Related Issue

https://app.clickup.com/t/2v0w820

Motivation and Context

How Has This Been Tested?

Checklist:

  • [ ] I have updated the documentation if necessary.
  • [ ] I have added tests to cover my changes, regression test if fixing an issue.
  • [x] This is a breaking change.

apopiak avatar Sep 05 '22 15:09 apopiak

Crate versions that have been updated:

  • runtime-integration-tests: v0.8.8 -> v0.9.0
  • parachain-runtime-mock: v0.1.7 -> v0.1.8
  • basilisk: v8.1.3 -> v8.1.4
  • pallet-duster: v3.1.11 -> v3.1.12
  • pallet-lbp: v4.6.6 -> v4.6.7
  • pallet-marketplace: v5.0.8 -> v5.0.9
  • pallet-xyk: v6.1.5 -> v6.2.0
  • pallet-xyk-liquidity-mining: v1.1.2 -> v1.1.3
  • pallet-xyk-liquidity-mining-benchmarking: v1.0.7 -> v1.0.8
  • primitives: v6.4.2 -> v6.4.3
  • basilisk-runtime: v90.0.0 -> v91.0.0
  • common-runtime: v2.3.5 -> v2.3.6
  • testing-basilisk-runtime: v90.0.0 -> v91.0.0

Runtime version has been increased.

github-actions[bot] avatar Sep 05 '22 15:09 github-actions[bot]

Codecov Report

Base: 43.89% // Head: 43.83% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (528e4fb) compared to base (3a7672d). Patch coverage: 29.16% of modified lines in pull request are covered.

:exclamation: Current head 528e4fb differs from pull request most recent head a22157e. Consider uploading reports for the commit a22157e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   43.89%   43.83%   -0.06%     
==========================================
  Files          61       61              
  Lines        4406     4428      +22     
==========================================
+ Hits         1934     1941       +7     
- Misses       2472     2487      +15     
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <0.00%> (ø)
node/src/testing_chain_spec.rs 0.00% <0.00%> (ø)
runtime/testing-basilisk/src/lib.rs 11.11% <0.00%> (-0.14%) :arrow_down:
pallets/xyk/src/lib.rs 82.18% <33.33%> (-1.50%) :arrow_down:
runtime/basilisk/src/lib.rs 21.22% <50.00%> (+0.55%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 05 '22 16:09 codecov[bot]

[upgrade       ] 2023-01-24 13:43:46        REGISTRY: Unknown signed extensions CurrencyBalanceCheck found, treating them as no-effect
[upgrade       ] 2023-01-24 13:43:46        METADATA: Unknown types found, no types for Lookup74
[upgrade       ] connected to Testing Basilisk Local Testnet 12.0.1-4c240952f runtime 88.0.0 node 8.1.3 x86_64-linux-gnu
[upgrade       ] current runtime version 88
[upgrade       ] Error: createType(Call):: Call: failed decoding sudo.sudoUncheckedWeight:: Struct: failed on args: {"call":"Call","weight":"{\"refTime\":\"u64\"}"}:: Struct: failed on weight: {"refTime":"u64"}:: Struct: Cannot decode value 100 (typeof number), expected an input object, map or array
[upgrade       ]     at createTypeUnsafe (/home/runner/work/Basilisk-node/Basilisk-node/scripts/upgrade-runtime/node_modules/@polkadot/types/create/createType.cjs:75:18)
[upgrade       ]     at TypeRegistry.createTypeUnsafe (/home/runner/work/Basilisk-node/Basilisk-node/scripts/upgrade-runtime/node_modules/@polkadot/types/create/registry.cjs:417:45)
[upgrade       ]     at TypeRegistry.createType (/home/runner/work/Basilisk-node/Basilisk-node/scripts/upgrade-runtime/node_modules/@polkadot/types/create/registry.cjs:409:17)
[upgrade       ]     at extrinsicFn (/home/runner/work/Basilisk-node/Basilisk-node/scripts/upgrade-runtime/node_modules/@polkadot/types/metadata/decorate/extrinsics/createUnchecked.cjs:28:21)
[upgrade       ]     at Object.decorated [as sudoUncheckedWeight] (/home/runner/work/Basilisk-node/Basilisk-node/scripts/upgrade-runtime/node_modules/@polkadot/api/base/Decorate.cjs:462:22)
[upgrade       ]     at main (/home/runner/work/Basilisk-node/Basilisk-node/scripts/upgrade-runtime/index.js:69:28)
[upgrade       ]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[upgrade       ] npm ERR! code ELIFECYCLE
[upgrade       ] npm ERR! errno 1
[upgrade       ] npm ERR! [email protected] upgrade: `node index.js testing_basilisk_runtime.compact.compressed.wasm`
[upgrade       ] npm ERR! Exit status 1
[upgrade       ] npm ERR! 
[upgrade       ] npm ERR! Failed at the [email protected] upgrade script.
[upgrade       ] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[upgrade       ] 
[upgrade       ] npm ERR! A complete log of this run can be found in:
[upgrade       ] npm ERR!     /home/runner/.npm/_logs/2023-01-24T13_43_46_752Z-debug.log

The upgrade error doesn't seem related to this PR?

apopiak avatar Jan 24 '23 15:01 apopiak

no idea why code coverage is failing here, any ideas?

apopiak avatar Feb 07 '23 12:02 apopiak

superseded by #599

apopiak avatar Feb 07 '23 14:02 apopiak