engine icon indicating copy to clipboard operation
engine copied to clipboard

Feat: support pbr ior

Open zhuxudong opened this issue 2 years ago • 1 comments

Please check if the PR fulfills these requirements

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature.

What is the current behavior? (You can also link to an open issue here)

F0 = 0.04 in all of the dielectric materials.

What is the new behavior (if this is a feature change)?

support F0 = ( (ior - 1)/(ior + 1) )^2, and KHR_materials_ior

Other information:

image

zhuxudong avatar Mar 16 '22 08:03 zhuxudong

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev/0.7@5086d41). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             dev/0.7     #694   +/-   ##
==========================================
  Coverage           ?   43.89%           
==========================================
  Files              ?      409           
  Lines              ?    21554           
  Branches           ?     2980           
==========================================
  Hits               ?     9462           
  Misses             ?    12092           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5086d41...23bf458. Read the comment docs.

codecov-commenter avatar Mar 16 '22 09:03 codecov-commenter

https://github.com/galacean/engine/pull/1487

zhuxudong avatar Apr 21 '23 08:04 zhuxudong