engine
engine copied to clipboard
Feat: Calculate ParticleRenderer BoundingBox
Please check if the PR fulfills these requirements
- [x] The commit message follows our guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Calculate ParticleRenderer BoundingBox
According to the subsequent design of localbounds
, this should be better:
According to the subsequent design of
localbounds
, this should be better:
Currently the result is the local bounds of the renderer.
Each calculation part is correspond to its GPU equivalent on a one-to-one basis.
Codecov Report
Attention: Patch coverage is 57.58684%
with 232 lines
in your changes missing coverage. Please review.
Project coverage is 68.26%. Comparing base (
4b28345
) to head (ffc86e8
). Report is 10 commits behind head on main.
:exclamation: Current head ffc86e8 differs from pull request most recent head de600a6
Please upload reports for the commit de600a6 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 66.09% 68.26% +2.17%
==========================================
Files 460 461 +1
Lines 23013 23550 +537
Branches 3370 3472 +102
==========================================
+ Hits 15211 16077 +866
+ Misses 6637 6221 -416
- Partials 1165 1252 +87
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.