engine icon indicating copy to clipboard operation
engine copied to clipboard

Feat: Calculate ParticleRenderer BoundingBox

Open JujieX opened this issue 1 year ago • 2 comments

Please check if the PR fulfills these requirements

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Calculate ParticleRenderer BoundingBox

JujieX avatar Jan 11 '24 08:01 JujieX

According to the subsequent design of localbounds, this should be better:

image

cptbtptpbcptdtptp avatar Jan 15 '24 03:01 cptbtptpbcptdtptp

According to the subsequent design of localbounds, this should be better:

image

Currently the result is the local bounds of the renderer. Each calculation part is correspond to its GPU equivalent on a one-to-one basis. image

JujieX avatar Jan 15 '24 07:01 JujieX

Codecov Report

Attention: Patch coverage is 57.58684% with 232 lines in your changes missing coverage. Please review.

Project coverage is 68.26%. Comparing base (4b28345) to head (ffc86e8). Report is 10 commits behind head on main.

:exclamation: Current head ffc86e8 differs from pull request most recent head de600a6

Please upload reports for the commit de600a6 to get more accurate results.

Files Patch % Lines
packages/core/src/particle/ParticleGenerator.ts 52.15% 101 Missing and 10 partials :warning:
...ore/src/particle/modules/ParticleCompositeCurve.ts 25.31% 51 Missing and 8 partials :warning:
packages/core/src/particle/modules/MainModule.ts 40.54% 22 Missing :warning:
...ackages/core/src/particle/modules/ParticleCurve.ts 38.88% 10 Missing and 1 partial :warning:
packages/core/src/particle/ParticleRenderer.ts 66.66% 6 Missing and 2 partials :warning:
...src/particle/modules/VelocityOverLifetimeModule.ts 57.89% 8 Missing :warning:
...kages/core/src/particle/modules/shape/BaseShape.ts 63.15% 6 Missing and 1 partial :warning:
...ckages/core/src/particle/modules/shape/BoxShape.ts 80.00% 3 Missing :warning:
...ges/core/src/particle/modules/shape/CircleShape.ts 92.30% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   66.09%   68.26%   +2.17%     
==========================================
  Files         460      461       +1     
  Lines       23013    23550     +537     
  Branches     3370     3472     +102     
==========================================
+ Hits        15211    16077     +866     
+ Misses       6637     6221     -416     
- Partials     1165     1252      +87     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 02 '24 09:04 codecov[bot]