engine
engine copied to clipboard
Support glTF materials remap
Please check if the PR fulfills these requirements
- [x] The commit message follows our guidelines
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
Related: https://github.com/oasis-engine/editor/issues/901
Codecov Report
Merging #1034 (a3537d0) into main (3e1428c) will decrease coverage by
0.05%
. The diff coverage is5.55%
.
@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 33.67% 33.62% -0.06%
==========================================
Files 334 335 +1
Lines 14454 14470 +16
Branches 2215 2219 +4
==========================================
- Hits 4868 4865 -3
- Misses 9060 9076 +16
- Partials 526 529 +3
Impacted Files | Coverage Δ | |
---|---|---|
packages/loader/src/gltf/parser/MaterialParser.ts | 1.35% <0.00%> (-0.08%) |
:arrow_down: |
packages/loader/src/gltf/parser/SceneParser.ts | 1.03% <0.00%> (-0.11%) |
:arrow_down: |
...oader/src/gltf/extensions/OASIS_materials_remap.ts | 33.33% <33.33%> (ø) |
|
packages/core/src/DisorderedArray.ts | 15.00% <0.00%> (-10.00%) |
:arrow_down: |
packages/math/src/Color.ts | 89.28% <0.00%> (-3.58%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.