effects-runtime icon indicating copy to clipboard operation
effects-runtime copied to clipboard

perf: opt timeline structure

Open wumaolinmaoan opened this issue 9 months ago • 1 comments

Summary by CodeRabbit

  • Refactor

    • Replaced TimelineComponent with ParticleBehaviourPlayable, ParticleSystem, ObjectBindingTrack, and Track across various components.
    • Updated CompositionComponent class to use objectBindingTracks instead of timelineComponents.
    • Removed TimelineComponent references and related logic from multiple classes and files.
  • New Features

    • Introduced new methods in ObjectBindingTrack and VFXItem classes for enhanced functionality.
    • Added time property to CompositionComponent class for improved time management.
  • Bug Fixes

    • Resolved issues related to the lifecycle and disposal of items by updating references to bindingItem.
  • Chores

    • Reordered and cleaned up import statements for better organization and readability.
    • Removed deprecated and unused code, including old classes and methods.
  • Tests

    • Updated test suites to reflect changes in component names and properties, ensuring continued accuracy and reliability.

wumaolinmaoan avatar May 16 '24 09:05 wumaolinmaoan

Walkthrough

The recent updates across several packages mainly involve the removal and replacement of TimelineComponent with ObjectBindingTrack and other related components. The changes also include method additions, import reorganization, and updates to class properties and logic to align with the new component structure. These modifications streamline the handling of animations and effects within the project.

Changes

File Path Change Summary
packages/effects-core/src/comp-vfx-item.ts Replaced TimelineComponent with ObjectBindingTrack; updated class properties and methods accordingly.
packages/effects-core/src/composition.ts Replaced rootTimeline references with rootComposition; added started property initialization.
packages/effects-core/src/index.ts Removed specific exports from fallback; added exports for canvas-pool and serialization-helper.
packages/effects-core/src/plugins/cal/calculate-item.ts Renamed TimelineComponent to ObjectBindingTrack; updated class properties and methods.
packages/effects-core/src/plugins/particle/particle-system.ts Removed TimelineComponent and Track imports; commented out related code.
packages/effects-core/src/utils/index.ts Removed export of timeline-component.
plugin-packages/model/src/plugin/model-item.ts Removed timeline property and related imports and methods.
plugin-packages/model/src/plugin/model-tree-item.ts Removed timeline property; reordered imports.
web-packages/demo/src/gui/inspector-gui.ts Removed block handling TimelineComponent; reordered imports.
web-packages/devtools/src/components/panel/InspectorView.vue Removed TimelineComponent from defaultOpenItems array.
web-packages/devtools/src/utils/ge.ts Removed TimelineComponent check; updated types for serializedDatas and effectsObjectDataMap.
web-packages/test/unit/src/effects-core/plugins/sprite/sprite-base.spec.ts Updated imports and usage of TimelineComponent to CompositionComponent.

In the code's vast and changing sea,
New tracks and bindings set us free.
Components shift, and methods grow,
With each commit, our projects flow.
🎨✨
From timelines past to compositions new,
The future's bright, and skies are blue.
🚀🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 16 '24 09:05 coderabbitai[bot]