effects-runtime
effects-runtime copied to clipboard
fix: 修复 iOS11/12 fontFamily 解析错误问题
Summary by CodeRabbit
-
New Features
- Improved font family handling across text-related components. Font family names are now sanitized for better platform compatibility, ensuring a more consistent and error-free display of text elements.
Walkthrough
Enhancements have been made to font management in the AssetManager
class in asset-manager.ts
. This involves utilizing getFontFamily
and isFontFamily
utilities for better font handling. The FontFace
constructor now employs getFontFamily
for correct font family names, and validation checks using isFontFamily
have been implemented to alert about unsupported font families.
Changes
File Path | Summary |
---|---|
packages/effects-core/src/asset-manager.ts |
Added imports for getFontFamily and isFontFamily . Updated FontFace constructor and added checks for font families. |
packages/effects-core/src/plugins/text/text-item.ts |
Modified setFontFamily method to include isFontFamily check, logging warnings and preventing changes for unsupported font families. |
Poem
Amongst the code's dance, fonts take their stance,
A rabbit appears with changes, a chance.
Fonts now inspected, warnings alight,
Each family tended, just right in its right.
WithgetFontFamily
and checks so neat,
AssetManager's task now complete.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>.
-
Generate unit testing code for this file.
-
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitai
in a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file.
-
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitai
in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table.
-
@coderabbitai show all the console.log statements in this repository.
-
@coderabbitai read src/utils.ts and generate unit testing code.
-
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pause
to pause the reviews on a PR. -
@coderabbitai resume
to resume the paused reviews. -
@coderabbitai review
to trigger a review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai resolve
resolve all the CodeRabbit review comments. -
@coderabbitai help
to get help.
Additionally, you can add @coderabbitai ignore
anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml
)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yaml
file to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.