flow-runtime icon indicating copy to clipboard operation
flow-runtime copied to clipboard

Errors are sometimes thrown with "warn" option

Open panrafal opened this issue 8 years ago • 1 comments

Issuehunt badges

This is a:

  • [x] Bug Report

Which concerns:

  • [x] flow-runtime

What is the current behaviour?

With the warn: true option, some invariants may still throw errors, for example this one: https://github.com/codemix/flow-runtime/blob/13e72fcc064bb6060c9ba49c58be3efe2f20ff40/packages/flow-runtime/src/flowTypes/%24ShapeType.js#L64


What is the expected behaviour?

Runtime should log a warning.


Which package versions are you using?

flow-runtime: 0.12


warn function (https://github.com/codemix/flow-runtime/blob/8bfdd7461f34d74bcb60247bf9b4b5644ab9e3b0/packages/flow-runtime/src/TypeContext.js#L1004) runs validation, but doesn't protect it from thrown errors


IssueHunt Summary

Backers (Total: $20.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

panrafal avatar May 16 '17 13:05 panrafal

@issuehunt has funded $20.00 to this issue.


issuehunt-oss[bot] avatar Jul 24 '19 13:07 issuehunt-oss[bot]