gagb
gagb
> @gagb Hey, is this pr ready for review and merge? Yes just marked it ready for review.
> LGTM, and remember to add a method to set `self.cancellation_requested` @IANTHEREAL, actually, I started implementing this and realized a mistake! When would an end user want to request cancellation?...
> > LGTM, and remember to add a method to set `self.cancellation_requested` > > @IANTHEREAL, actually, I started implementing this and realized a mistake! > > When would an end...
> > > > LGTM, and remember to add a method to set `self.cancellation_requested` > > > > > > > > > @IANTHEREAL, actually, I started implementing this and...
> What if another process load the same assistant and request cancellation? Yes, this is feasible if the second process can access the `thread_id`. It's even easier if that process...
> > > > > > LGTM, and remember to add a method to set `self.cancellation_requested` > > > > > > > > > > > > > >...
@sidhujag could we get a review?
> @gagb this PR is approved but I am not sure if you'd like to merge it from the discussion. Could you clarify? Thanks. I don't understand?
closing because of inactivity.
Nice PR @afourney. Suggestions: - add notebook example showing usage - update documentation to point to notebook