Sampler icon indicating copy to clipboard operation
Sampler copied to clipboard

Add parallelization for faster dependency download

Open johlju opened this issue 6 months ago • 2 comments

Pull Request

Pull Request (PR) description

Changed

  • When resolving dependencies using PSResourceGet, it now uses parallelization to more quickly get the dependencies downloaded.

Task list

  • [x] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • [x] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • [x] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • [ ] Documentation added/updated in README.md.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

johlju avatar Jan 28 '24 16:01 johlju

I'm not certain of this change. It might conflict when downloading modules that uses the same dependent module. 🤔 Then two modules will try to write to the same folder... Not sure it is possible to prevent that.

johlju avatar Jan 28 '24 16:01 johlju

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5d47846) 81% compared to head (7d833b6) 81%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #462   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        44     44           
  Lines      2328   2328           
===================================
  Hits       1904   1904           
  Misses      424    424           

codecov[bot] avatar Jan 28 '24 16:01 codecov[bot]