Results 918 comments of dan

>Though it was not a best practice, V17 was OK with this. I want to make it clear that it worked accidentally and in a narrow range of circumstances. You...

The issue is the early return. Put the return after calls to Hooks. Please add the linter to your setup to detect these issues at compile time as originally intended.

Would be nice to figure out what causes the restart! I don't think our code is doing this intentionally

@ngencokamin I'm guessing there isn't much test-oriented follow up here, if you'd like to dig into the cause I'd assume it's something related to the Android manifest settings and whatever...

Does configuration change _always_ restart an activity?

Yeah. To set expectations, we can't merge this as is — there's quite a bit of exploratory work we need to do to see if it's feasible to make it...

Thanks for exploring this! I'm going to try to pick it up from work in https://github.com/bluesky-social/social-app/pull/3612. This PR strays a bit far behaviorally from our other tabbed interfaces because we...

thanks, we did a more extensive fix here https://github.com/bluesky-social/social-app/pull/4941

I think we should just nix that button and move the dot into the tab bar which is pretty standard. Second tap on the bar already scrolls you up.

@arfianadam @gedeagas @regalius @rizafahmi @resir014 @grikomsn Can you please confirm if you will be able to maintain and steer this translation? We need to get https://github.com/reactjs/translations.react.dev/blob/main/langs/id.json to match the current...