meteor-famous-views
meteor-famous-views copied to clipboard
gadicc
WIP, fview-demo
Work in progress. Simple app using famous-views. Mobile-first, end goal is fully responsive for all sizes.
Currently best viewed on mobile or in mobile emulation: http://fview-demo.meteor.com/ https://github.com/gadicc/fview-demo
@trusktr and @PEM--, thought you might be interested to see this, especially the total 60 lines of templating all in Jade. The JS weighs in at 70 lines, but would be a lot shorter in CS, I admit :>
Demos off two cool new things in the new version released today, reactive properties on scrollview (unfortunately the pageChange even is a bit borked, but I worked around it a little), and spacebar text inside an attribute value. Neither is documented yet but they're mentioned in the History and seen in use here.
Nice. Love the idea of a real world demo with RWD in mind.
Could I add the following minor adjustments to it or do you prefer experimenting stuff on your own?
- Remove the CSS to for a drop in smaller replacement of styles in CS: This speeds up the initial screen loading on mobile and allow sharing value between the logic and the styles.
- Turn your JS in CS.
For the hamburger button, there is this really cool animation that @IjzerenHein did: https://github.com/IjzerenHein/famous-animatedIcon
Happy for you to contribute :) Our minor collaboration has been pretty fun so far. Added you as a collaborator. I guess by the end of it you'll have me coding natively in CS haha.
Ah, that's cool... yeah I rate we can squeeze that in. I'm out of time for today but will try integrate it tomorrow/monday.
Looks sweet! Just needs to fill my whole screen on Nexus 5 Chrome. xD
Do email attachments work? Do you see the screenshot?
/#!/JoePea On Nov 8, 2014 7:09 AM, "Gadi Cohen" [email protected] wrote:
Happy for you to contribute :) Our minor collaboration has been pretty fun so far. Added you as a collaborator. I guess by the end of it you'll have me coding natively in CS haha.
Ah, that's cool... yeah I rate we can squeeze that in. I'm out of time for today but will try integrate it tomorrow/monday.
— Reply to this email directly or view it on GitHub https://github.com/gadicc/meteor-famous-views/issues/132#issuecomment-62260951 .
Deadly on Nexus 5. I've just checked on my midp (an old HTC Desire C) and it works. Pretty weird. I use this device as I know it is normally the worst case scenario (you should see my guys when I test their apps on it, it is always a funny moment).
It works on the stock browser as well as Chrome. I'm charging my Android tablet to try reproducing your issue.
@gadicc I've updated the sources. Now everything is in CS.
There is still some stuff that we should take care of: CSSRules are still contained in famous-views as CSS files. Thus, I can't remove the last bits of calls.
I've removed the call to famous.polyfills so that users can call it themselves as stated in the documentation (Quickstart / General help).
In the view-demo, when the animation of the icons takes place, there is a little glitch: the main window is paused for at least one frame. It breaks its fluidity. I think that the reactive event on Template.homePageIndicator.helpers is not synchronized with Famo.us's Engine. It should be called with an Engine.nextTick.
:-1: Dawn, I can't reproduce @trusktr issue with his Nexus 5. I've tried an Android tablet (a Samsung Galaxy Tab) and it flies like native. @trusktr could you help us on this?
Haven't had time this weekend for fun stuff. Just work. :'( I'll be back to try and see why this happens. Of thing is I tried this again today and it randomly changes size, so it's sometimes a little bigger, but still not full window.
/#!/JoePea On Nov 8, 2014 12:47 PM, "Pierre-Eric Marchandet" [email protected] wrote:
[image: :grin:] Dawn, I can't reproduce @trusktr https://github.com/trusktr issue with its Nexus 5. I've tried an Android tablet and it flies like native. @trusktr https://github.com/trusktr could you help us on this?
— Reply to this email directly or view it on GitHub https://github.com/gadicc/meteor-famous-views/issues/132#issuecomment-62278157 .
No worries, also only have very limited time to work on this, but hopefully bit by bit it will amount to something.
@PEM-- , thanks for all the changes and updates!
@trusktr, it's weird about the sizing... we disable user zooming and let famo.us handle the sizing, so that's pretty weird. even on nexus 5 on the google emulator, it works fine. well, we'll track it down eventually i guess...
re performance, also pretty weird. i saw what you mean, but it's hard to reproduce. even with lagometer and some of my own code to log frame drops to the console, it only ever happens occasional. i think the code is ok because we only call setTransform(), and this shouldn't have any immediate performance impact and rather just animate according to Famo.us commits.
and yeah will add that icon when I have a chance.
Seems like another good candidate for a plugin :smile:
You should have it tonight.