Gadi Cohen

Results 637 comments of Gadi Cohen

Hey :) Ok that sounds good. I'm a bit hazy on all the logic and don't have time to review the current code now. The only thing that comes to...

Ooh, yay, awesome!! Thanks for the rundown... super helpful for me having not looked at the code in so long and being under time constraints now. Actually, I think it...

Hey @alvestjo. As per other issue docs are back up. Just note that any info in the READMEs supersede info on the online docs. Seems like the initial load is...

Hey, wow, looks like I got ahead of myself when I did this. Thanks for tracking this down! It's not well tested but can you give `msgfmt:[email protected]` a spin and...

Yes, you're right, in the [code that handles this](https://github.com/gadicc/meteor-messageformat/blob/895e9684a5a4852135c988022d2b8be1ef7649d3/packages/core/lib/msgfmt-client.js#L222-L238), on line 228, there's a TODO there that I should report if this doesn't work! Will get on that. As you...

Hey @aviavia. Do you think this is the same as #249? I think the simplest way for now is to just add `msgfmt.setLocale('he')` in the client code (you could probably...

Oh, I guess if you're doing it straight after `msgfmt.init()`, you probably have that in an isomorphic file, so you'd need some extra code to keep it just on the...

Hey Max This is another surprising one :) Files are only handled if they match [`/\.(html|js|coffee|jsx|jade)$/)`](https://github.com/gadicc/meteor-messageformat/blob/v2/packages/extract/extract.js#L54) and then `handler.html` etc are all defined in the same file. Is it possible...

@Kombustor, yeah, I embarrassingly never quite finished this up because of all the changes to Meteor over the last two years (and the consequent impact on my time). There were...