Gadi Cohen

Results 475 comments of Gadi Cohen

:open_mouth: I'm a little in shock at how quickly you did this!! Reviewing now :pray: :pray:

Thanks @nocodehummel, looks like we're off to a great start here :pray: I must admit, I had never actually thought about having fetchDevel and JFMC code co-exist. It's actually a...

Yeah, I'd love to move off **`node-fetch`**. And indeed, we only need to support Node 18+ now. But [`Headers#getSetCookie()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie) is only available in Node 19.7.0 as per the compatibility matrix...

Perfect! Thanks so much. Sure, no pressure whatsoever on my side, take your time, and thanks again :) Yeah in yahoo-finance2 we don't use `getSetCookie` since we're using `node-fetch` which...

Hey @nocodehummel, just checking in. Absolutely no pressure from my side, I'm also swamped with stuff, just wanted to see how things are going your side and if I can...

Thanks, @nocodehummel, that's perfect. Never any pressure from my side, just wanted to check in. Good luck with your other priorities, enjoy the holidays, and we'll touch base after the...

Quoting @eddie-atkinson from https://github.com/gadicc/node-yahoo-finance2/issues/719#issuecomment-2076253522 (replying to me): >> The flow is actually: a) typescript interfaces for all the APIs, b) typescript interfaces -> json schema, c) ajv to validate input...

Firstly, @eddie-atkinson, thanks so much both for raising this issue but most especially for your preliminary research and helpful discussion. Wow, I'd never heard of `@sinclair/typebox` before. It looks super...

cc: * @nocodehummel (who's working at refactoring the testing architecture): FYI, and in case you have any input * @dtslvr (Ghostfolio author): FYI, but probably doesn't have much impact for...

Amazing! You're the best :clap: Thanks again :grin: