Gadi Cohen

Results 475 comments of Gadi Cohen

Hey @eddie-atkinson, thanks so much. Was AFK over the weekend, will review now. Very exciting to finally be able to drop `node-fetch` (despite how well it's served us all these...

Hey @CristianSpatari Thanks for the report. Unfortunately I don't have anytime to look into this in depth, but I'll give some comments that may help. 1) `fetchDevel.js` is a dynamic...

Hey @jayehernandez, thanks for chiming in. Well, that line is already a dynamic import, that is only imported when needed (i.e. when `fetchDevel()` is called). It should not be imported...

Amazing, thanks so much, @jayehernandez; greatly appreciate the feedback :raised_hands:

Oh wow, nice catch! Thanks as always for your valuable contributions here :pray: Ok sounds great! I hope someone who has been experiencing this issue will be able to test...

Thanks! Sure, yeah, feedback welcome. It's my go to package now every time I'm developing new code around an API, and amazing for test driven development. The new approach via...

Hey @AngelNBazan, thanks for checking out the code and confirming, that's a great help! And of course, again, to @z3nful for all his awesome work on this and other issues...

Sorry, looks like semantic-release doesn't handle reverted commits... this isn't fixed yet :sweat_smile: (I deleted the previous "fixed" / "release" message)

Big thanks to @nordicgit70 for taking a stab at this while @z3nful and I have been super bogged down with other stuff! This looks like a great way to finally...

:tada: This issue ~has been~ may be resolved in version 2.9.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/yahoo-finance2/v/2.9.0) - [GitHub release](https://github.com/gadicc/node-yahoo-finance2/releases/tag/v2.9.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket: