circle-to-polygon icon indicating copy to clipboard operation
circle-to-polygon copied to clipboard

Published 20 hours ago • verified publisher icon gabzim

Add License

Open gabzim opened this issue 5 years ago • 5 comments

We should pick a license and add it to the project files

gabzim avatar Feb 18 '20 14:02 gabzim

Haven't you already picked ISC? Or did you mean to all files in the project?

johachi avatar Feb 20 '20 14:02 johachi

Yes I meant in the project files, is that necessary? I see a lot of open source projects doing it and figured you might need to add it to every file.

gabzim avatar Feb 20 '20 14:02 gabzim

I googled a bit. It seems like we should have a LICENSE.txt or a LICENSE.md in the root of the project, and then also a disclaimer in every source file.

I think the disclaimer (for each source file) could easily be written when linting the file.

johachi avatar Feb 21 '20 15:02 johachi

@gabzim I added a license file and a section to the readme in this PR: #20

Could you please see if you can add license info automatically in the source file on linting?

TODO:

  • [x] Add license.txt
  • [x] Add license info to readme.md
  • [ ] Add license disclaimer to source files

johachi avatar Feb 22 '20 08:02 johachi

I see now that you assigned yourself to this issue. Hope you don't mind that I made a small PR addressing some points on this PR. Feel free to reject it if it's not what you imagined :)

johachi avatar Feb 22 '20 13:02 johachi