Juan Calderon-Perez

Results 1417 comments of Juan Calderon-Perez

👍 For these changes, pending the tasks from the list and updating the test to cover the lines missing in coverage report.

@sprappcom Can you provide an example of prefork vs no-prefork memory usage. What is the definition of "a lot of memory" in this case? Are we talking KB, MB, GB?

@wnnce io.Copy would load the whole thing to memory. Not ideal if the file is big.

@nilsfriess You're missing permissions in your workflow: ```yaml permissions: # deployments permission to deploy GitHub pages website deployments: write # contents permission to update benchmark contents in gh-pages branch contents:...

I'm pretty sure the pin is needed. Not all tools behave the same way.

@reyammer That should be fine, the main thing will be keeping track of which versions `numpy` is dropping. I'm surprised their lowest supported is `3.10` when `3.8/3.9` are still not...

> think it would make sense to put everything in a new branch for v3 and upgrade everyone to the latest version of the dependencies and only support the latest...

@efectn If you can add the command for generating the `msgp` to the Makefile.

> > @efectn If you can add the command for generating the `msgp` to the Makefile. > > you mean this https://github.com/gofiber/fiber/blob/main/Makefile#L61-L67 Yes