Juan Calderon-Perez
Juan Calderon-Perez
@coderabbitai Is the RLock needed in any other method of app.go?
Adding a lock on these functions causes unit-tests to never finish since the locks are fighting with each other.
@luzzodev @Synrom The discussion in starlette was shutdown immediately. Is the plan to add this to FastAPI then?
> I can't figure out why the tests are failing. Something not quite right with Fasthttp You have a race condition in the SendEarlyHints test: ```console === Failed === FAIL:...
> How can I fix it? It's not obvious where the race-condition is. Seems the failure comes from Fasthttp? It happens when you call `return c.fasthttp.EarlyHints()`
@pjebs I kind of agree with this. We will discuss it internally.
@pjebs Although it is tempting to unify them, implementing the full `context.Context` interface on `fiber.Ctx` has subtle pitfalls: - It would misrepresent or sabotage the built-in concurrency & lifecycles of...
@pjebs The fasthttp context already implements the functions from #3382 See: - Deadline() https://github.com/valyala/fasthttp/blob/master/server.go#L2825 - Done() https://github.com/valyala/fasthttp/blob/master/server.go#L2835 - Err() https://github.com/valyala/fasthttp/blob/master/server.go#L2848 - Value() https://github.com/valyala/fasthttp/blob/master/server.go#L2863
Relevant https://github.com/valyala/fasthttp/issues/1998
@sixcolors I left a review on the PR, waiting for @pjebs