Gabriel Mougard

icon indicating a website link gabrielmougard.github.io

icon company @canonical icon location France icon location Software Engineer, Robotic hobbyist(ROS/Gazebo), system programming (C++ mainly, Rust), backend programming (Go), Data engineering (Python)

Results 68 comments of Gabriel Mougard

Invalid used by url on storage pool

@edlerd Shall I close this for now then?

lxd-metadata: Annotate codebase for `tpm` device config keys

@ru-fu updated

lxd-metadata: Annotate codebase for `proxy` device config keys

@ru-fu udpated

lxd-metadata: Annotate codebase for `proxy` device config keys

@tomponline the https://ceph.io link is down making the doc tests to fail but else it should be fine.

Device: Don't remove an existing target directory when unmounting a `disk` device if the original dir hasn't been created by LXD

Working on the integration tests now.

Device: Don't remove an existing target directory when unmounting a `disk` device if the original dir hasn't been created by LXD

Tests should be ready

Device: Don't remove an existing target directory when unmounting a `disk` device if the original dir hasn't been created by LXD

Also, @tomponline, the `deviceVolatileSetFunc` function, which calls the `VolatileSet`, updates the DB. I think this is good to persist this information though. Removing an existing target dir like `/opt` for...

Device: Don't remove an existing target directory when unmounting a `disk` device if the original dir hasn't been created by LXD

@tomponline I implemented the logic for the VM as well within the lxd-agent. I tested it on my side without an issue.

Device: Don't remove an existing target directory when unmounting a `disk` device if the original dir hasn't been created by LXD

@tomponline that's interesting! I just didn't know about this `eventsProcess()` logic tbh. You're right, if we could handle the unmount logic as part of an event hook, that'd be better...

Device: Don't remove an existing target directory when unmounting a `disk` device if the original dir hasn't been created by LXD

@tomponline I moved the unmount logic bit into the `eventsProcess()` function as you required. I reproduced the integration tests on my side with a VM, no issue so far.