js-openclient icon indicating copy to clipboard operation
js-openclient copied to clipboard

js-openclient/heat/v1/stacks.js not handling error callback

Open aheifetz opened this issue 10 years ago • 1 comments

In the file js-openclient/heat/v1/stacks.js

In the create function, it deletes the reference to the error callack:

if (params.error) delete params.error;

but later we call manager.safe_complete to handle the error:

this._super(params, function (err, result, xhr) { if (err) return manager.safe_complete(err, null, null, params, callback);

However, safe_complete depends on params.error being a function to handle the callback.

Does the code need to delete the params.error ?

aheifetz avatar Feb 21 '15 19:02 aheifetz

BTW - great library!

aheifetz avatar Feb 21 '15 19:02 aheifetz