node-git-server icon indicating copy to clipboard operation
node-git-server copied to clipboard

Allow any ref, not just tags or branches

Open mattwynne opened this issue 4 years ago • 4 comments

The current regex for parsing a receive-pack payload assumes the ref will be of the form:

refs/tags/:tag-name
refs/heads/:branch-name

We'd like to be able to push arbitrary refs, like

refs/any/thing/we/like

The goal of this PR is to make that change, with tests and any neccesary changes to the outside API / internal model.

To do:

  • [ ] fix the regex so it works for any number of slashes/segments (currently assumes the form refs/one/two)
  • [ ] tests / API changes

mattwynne avatar Mar 15 '21 05:03 mattwynne

This is great, any updates on tests @mattwynne ?

gabrielcsapo avatar Apr 18 '21 01:04 gabrielcsapo

I'm afraid I haven't had any time to give this attention since I shared my spike code. I got stuck on #81 - because I want to trust my environment before I start adding more tests.

mattwynne avatar Apr 23 '21 19:04 mattwynne

I can unblock you on that this weekend!

gabrielcsapo avatar Apr 23 '21 19:04 gabrielcsapo

@mattwynne tests should be fixed, CI is now running via GitHub actions!

gabrielcsapo avatar Apr 25 '21 04:04 gabrielcsapo