node-git-server icon indicating copy to clipboard operation
node-git-server copied to clipboard

If the tag contains `00`, it will break there

Open sounisi5011 opened this issue 2 years ago • 0 comments

I tried to push the following tag: v72.94001.10 However, the tag passed to the tag event was the following value:

const { Git } = require('node-git-server');

const repos = new Git('path/to/tmp', {
  autoCreate: true,
});

repos.on('tag', (tag) => {
  // tag.version === 'v72.94' // What!?
});

repos.listen(49152, { type: 'http' }, () => {
  // ...
});
repos.server.on('error', err => { throw err });

Apparently, tag names are cut off when 00 is encountered. I have looked into the reason for this and found the following regular expression to be the cause.

https://github.com/gabrielcsapo/node-git-server/blob/2ab22a4d3f1a9c77314236c401e176f994f2f758/src/service.ts#L13

This pattern is defined so that tag names after spaces, null characters, or 00 are not retrieved. Why? Tag names (and branch names) can contain 00. What is the reason for excluding anything after 00?

sounisi5011 avatar Mar 17 '23 15:03 sounisi5011