font-detect-js icon indicating copy to clipboard operation
font-detect-js copied to clipboard

Refactored version doesn't work with new jQuery

Open elky opened this issue 13 years ago • 0 comments

Hi there,

Refactored version (from the branch "refactored") looks very nice in terms of code. But it doesn't work with latest jQuery version.

I know that this project wasn't updated for 4 years but anyway it would be cool to add such compatibility.

Not worked piece of code is in font-detect.js:

return {

    loadSWF: function() {
      _loadSWF();
    },

    fonts: function() {
      // Use when doing static publishing
      //var swf = swfobject.getObjectById(_swfObjectId);

      // Works with dynamic publishing
      var swfObj = document.getElementById(_swfObjectId);
      var fonts = swfObj.fonts();
      return _filterFonts(fonts);
    }
  }

Could you have a look on it please? Seems not difficult to fix.

Thanks

elky avatar Oct 17 '12 11:10 elky