sonar-gitlab-plugin icon indicating copy to clipboard operation
sonar-gitlab-plugin copied to clipboard

Findings are not unresolved discussions

Open lealoureiro opened this issue 4 years ago • 1 comments

Hello,

First of all thank you for support in developing this plugin.

At moment I'm trying to use version 4.0.0 of the plugin with this options: -Dsonar.gitlab.ci_merge_request_iid=$MERGE_REQUEST_ID -Dsonar.gitlab.merge_request_discussion=true but this discussions are attached to diff but not appearing as unresolved blocking the Merge Request...

Is this expected behaviour ? I would expect to appear as unresolved like the ones created by peer reviews.

Thanks in advance!

Regards, Leandro

lealoureiro avatar Oct 21 '19 12:10 lealoureiro

I just got this working for a project, it looks like the MR discussion feature (https://github.com/gabrie-allaigre/sonar-gitlab-plugin/pull/216) was merged in after the latest release, so I had to download and compile a new version of this plugin for it to work.

drampelt avatar Nov 01 '19 19:11 drampelt