sonar-gitlab-plugin icon indicating copy to clipboard operation
sonar-gitlab-plugin copied to clipboard

Multiple project.settings (with commit status) in a single pipeline

Open sseypt opened this issue 5 years ago • 1 comments

Hi.

We are using multiple sonar-project.properties in different jobs in a single pipeline. So far so good 👍 That way we can have certain modules analyzed more strict that others.

We now came across an issue with the static status name - they are overwriting each others:

grafik

Reason for this is private static final String COMMIT_CONTEXT = "sonarqube"

https://github.com/gabrie-allaigre/sonar-gitlab-plugin/blob/8ca448142890e0246c832f83aab4da340743a0e9/src/main/java/com/talanlabs/sonar/plugins/gitlab/GitLabApiV3Wrapper.java#L211

https://github.com/gabrie-allaigre/sonar-gitlab-plugin/search?q=COMMIT_CONTEXT&unscoped_q=COMMIT_CONTEXT

We'd like to stick to gitlab's commit status and I'm wondering if there's another way or is it possible to make it configurable?

Before I could come up with a pull request, I'd like to discuss it first 😄

Best regards, Steve

sseypt avatar Apr 01 '19 05:04 sseypt

Hi, Yes, you propose PR. Thanks

gabrie-allaigre avatar May 10 '19 07:05 gabrie-allaigre