sonar-gitlab-plugin icon indicating copy to clipboard operation
sonar-gitlab-plugin copied to clipboard

Published 20 hours ago • verified publisher icon gabrie-allaigre

SonarQube 7.6 Marketplace Missing GitLab Plugin

Open jonnygrm opened this issue 5 years ago • 21 comments

Hi, I noticed that our fresh install of SonarQube 7.6 does not have GitLab as an available option in the marketplace menu. The only GitLab related plugin displaying is GitLab Auth. Is this a comparability issue? Thanks Jonny

jonnygrm avatar Mar 18 '19 12:03 jonnygrm

Hi,

I have the same issues, no Gitlab plugin in a fresh install of SonarQube 7.6, and also on SonarQube 7.7..

Thanks

vlandemaine-orange avatar Mar 21 '19 11:03 vlandemaine-orange

Hi, same here. Only GitLab Auth Plugin available in Marketplace. Thanks Marco

marcolindner avatar Mar 22 '19 09:03 marcolindner

Hello,

Sorry I no longer use SonarQube for several months. I received a message from SonarQube 1 year ago, they will integrate in their BranchPlugin GitLab (as for Github) And it really discouraged me to continue. I will not do any more evolution on the plugin. I have more time to spend. Following the evolutions of Sonar and GitLab take too much time.

Thank you

gabrie-allaigre avatar Mar 22 '19 10:03 gabrie-allaigre

Hi Gabriel !

Thanks a lot for your work on this plugin. If you don't plan any futur evolution on the plugin will you release the 4.0.1 version ? (currently SNAPSHOT).

ghost avatar Mar 25 '19 09:03 ghost

Hi @gabrie-allaigre, maybe you could do a handover? I would not mind to review the current issues and merge them if appropriate, and pretty sure others would also offer their help. IMO this is a great tool, and I would love to keep updating it from sonar itself

dmarin avatar Mar 25 '19 11:03 dmarin

@gabrie-allaigre I also would love to see a handover happen. As long as Sonar has not released an official version of this tool, we definitely need this.

dominikmontada avatar Mar 26 '19 00:03 dominikmontada

Hi @gabrie-allaigre, maybe you could do a handover? I would not mind to review the current issues and merge them if appropriate, and pretty sure others would also offer their help. IMO this is a great tool, and I would love to keep updating it from sonar itself

Either this or we should mark this repo here as deprecated / unmaintained, create an org account for this and invite contributors and maintainers to keep this project alive.

DanielRuf avatar Mar 26 '19 08:03 DanielRuf

Hi @gabrie-allaigre, This project ^ your plugin is way too much important to become unmaintained. The community is ready to step up and I would help as well. Please let us all work on this project together.

dmpe avatar Mar 27 '19 09:03 dmpe

I have a team that would be willing to help keep this up to date as well - we make active use of this plugin for automated code review, and it's a core part of our workflows. In recent weeks we've explored building our own version of it, but in my opinion that work would be better put towards helping the broader community maintain this one.

alephtwo avatar Mar 27 '19 14:03 alephtwo

I created this ticket on sonar --> https://community.sonarsource.com/t/support-gitlab-plugin-for-sonarqube/8193?u=david_marin To be fair I would rather keep the plugin under @gabrie-allaigre if possible since he did the hard work :) but the "community" sounds good to me too :)

dmarin avatar Mar 27 '19 16:03 dmarin

But is it really possible to keep this plugin alive? SonarQube 7.7 dropped the sonar.analysis.mode parameter (https://docs.sonarqube.org/latest/setup/upgrade-notes/), which this plugin relies on, and I'm not sure if there is a replacement for that. Instead, SonarSource suggests moving to a commercial Developer edition that includes a Pull Request Analysis feature (https://docs.sonarqube.org/latest/analysis/pull-request/) but that does not support GitLab. They deprecated the GitHub plugin for the same reason (https://docs.sonarqube.org/display/PLUG/GitHub+Plugin). I wish there is a replacement for the sonar.analysis.mode parameter but not sure if there really is.

alexander-frolov avatar Mar 27 '19 23:03 alexander-frolov

@alexander-frolov As far as I am aware you don't need the analysis parameter, at least when running the developer version, since it supports branch analysis. That is exactly what we were doing: we just ran a branch/merge request analysis and didn't use the sonar.analysis.mode parameter.

But you do raise a good point, as I'm not sure what people running the community edition can do about this.

dominikmontada avatar Mar 28 '19 00:03 dominikmontada

The developer edition is quite expensive for us, so we've been relying on a few workarounds to get the functionality. The loss of the sonar.analysis.mode parameter has been a long time coming, but it's still a huge blow. If it's gone, then it really does call into question whether or not maintaining this plugin is feasible long term.

alephtwo avatar Mar 28 '19 13:03 alephtwo

Hello, That's what I'm going to do:

  • Finish version 4.1.0, add / edit discussion in MR and resolve. This version use only SonarQube >= 7.0 and <= 7.6
  • New version 5.0.0, remove all code for preview mode. And add compatibilty for SonarQube >=7.7

Voilà.

I can not give a date, I put myself back in it. I will try to do it quickly.

gabrie-allaigre avatar Mar 28 '19 16:03 gabrie-allaigre

@alexander-frolov The sadest part in this is that they won't support GitLab officially any time soon :-(

https://community.sonarsource.com/t/merge-requests-support-for-gitlab/806/12

jairbubbles avatar May 02 '19 20:05 jairbubbles

New version 5.0.0, remove all code for preview mode. And add compatibilty for SonarQube >=7.7

@gabrie-allaigre could you share some hints on how do you intend to support MRs with 7.7+? The good guys maintaining a similar Stash Sonar Plugin don't see a way to handle this: https://github.com/AmadeusITGroup/sonar-stash/issues/202#issuecomment-500195455

jakub-bochenski avatar Jun 26 '19 15:06 jakub-bochenski

(Maintainer of the mentioned sonar-stash plugin)

If there is an easy way of supporting this feature with new SQ I am indeed interested. If it requires major rework it may make sense to do it in a way that it can be used with both Gitlab and Bitbucket.

(Personally I would not be involved for that, but hopefully somebody would step up)

t-8ch avatar Jun 27 '19 10:06 t-8ch

Hi,

What do you guys think of my comment here? Would it make sense to create a core project that does the analysis and then simply add "providers" for it to enable it to publish the results to the respective provider implementation (Stash, Gitlab, Github, etc)?

Perhaps we could join up and come up with a solution to the problem both projects are having?

carlspring avatar Jun 27 '19 11:06 carlspring

@gabrie-allaigre - Wanted to see how things are going with the 5.x plugin as we have updated to version 7.9 and would like to determine if we can utilize the plugin at some point. If not we may look at other alternatives for usage of API's, etc.

lbammes avatar Jul 11 '19 21:07 lbammes

On SonarQube developer edition, they don't need the preview mode because branch analysis is enabled.
So removing preview mode is a way to pull users to a commercial version.

SonarQube andGilab have also conflicting business models: Gitlab tries to convince users to stay inside Gitlab and to give up external services. In consequence neither of Gitlab or SonarQue is willing to put resources to help developing a plugin...

However there is still a community branch plugin for SonarQube. Using it would allow to remove the need of the preview mode.
If I do so, will the Sonar GitLab Plugin work with 7.7+ versions of SonarQube ?

stalb avatar Jul 28 '19 20:07 stalb

Is there any way to support sonarqube 8.2 community edition?

shouldnotappearcalm avatar Apr 24 '20 15:04 shouldnotappearcalm