tcp_client.h missing <fcntl.h> include — causes compilation failures

Open maordadush opened this issue 1 month ago • 2 comments

When building on Linux/Unix, spdlog/details/tcp_client.h fails to compile because it uses fcntl(), F_GETFL, F_SETFL, O_NONBLOCK, F_SETFD, and FD_CLOEXEC without including <fcntl.h>.

git log

commit 3f03542d2eb4952e3b279d9cad9098d370b7be57 (HEAD -> v1.x, origin/v1.x, origin/HEAD)
Author: gabime <[email protected]>
Date:   Sun Nov 30 11:16:53 2025 +0200

    Remove warning 4834 suppression

Dec 08 '25 09:12 maordadush

PR is welcome.

Dec 08 '25 10:12 tt4g

https://github.com/gabime/spdlog/pull/3497

Dec 08 '25 10:12 maordadush