In fmt master, basic_format_string has moved from base.h to xchar.h

[pratikpc]

Took place in this commit

This change causes compile time errors due to:-

1. Using SPDLOG_FMT_EXTERNAL and using fmt master
2. spdlog/common needing basic_format_string without SPDLOG_USE_STD_FORMAT https://github.com/gabime/spdlog/blob/e593f6695c6065e6b345fe2862f04a519ed484e0/include/spdlog/common.h#L367-L370
3. xchar.h not being included due to absence of the specified definitions https://github.com/gabime/spdlog/blob/e593f6695c6065e6b345fe2862f04a519ed484e0/include/spdlog/common.h#L56-L58

[pratikpc]

I solved it personally for myself by removing the ifdefs around the headers

[tt4g]

This is a change that has not yet been released, so we will figure out how to address it after its release.

[Vertexwahn]

I run in exact the same issue -> https://github.com/gabime/spdlog/issues/3258

[ahoarau]

Same issue here (wrongly addressed in https://github.com/gabime/spdlog/pull/3274)

[martingalvan-volue]

Hi @gabime , has this issue been fixed? Thanks.

[Vertexwahn]

fixed many moons ago...

[martingalvan-volue]

fixed many moons ago...

Thanks. This ticket should then be closed (ideally with a link to the commit which fixed it).