react-scrollable-anchor icon indicating copy to clipboard operation
react-scrollable-anchor copied to clipboard

Does total rerender for route with react-router custom history when scrolling sections

Open tchock opened this issue 6 years ago • 1 comments

What I do: I am using a custom history (but still using the browser history) in react-router and scroll through sections.

What I see: It re-mounts the route component because react-router handles this as a complete route change causing jumping to the top of the page.

What I expect: The hash should change, but the route should not be re-rendered.

Possible solution: passing a custom hash update function to the ScrollableAnchor component that will handle the hash change in a custom matter (using the history prop that react-router provides).

tchock avatar Jul 05 '18 14:07 tchock

@tchock I have the same problem as you, so I hope someone (@gabergg , @bjacobel, @Marcel-G, @savtwo) can check this pull request!

Thank you in advance mmock

moritzmock avatar Oct 08 '19 14:10 moritzmock