react-scrollable-anchor icon indicating copy to clipboard operation
react-scrollable-anchor copied to clipboard

Published 20 hours ago • verified publisher icon gabergg

Prevent a Hash change triggered scroll from triggering hash recalculation

Open tiagoroldao opened this issue 7 years ago • 3 comments

Fixes #23

tiagoroldao avatar Sep 30 '17 17:09 tiagoroldao

I don't think this has been updated in the npm module. The module states that the files are up to date but this forced scroll change does not exist in the code and the hash recalculation is still occurring. Also the code in Manager.js, ScrollableAnchor.js, and index.js are wildly different to the code in the git repo

maxvrancken avatar Oct 24 '17 17:10 maxvrancken

I'm not sure I follow. forcedScroll was added to stop hash recalculation, so it is normal that it does occur, precisely because forcedScroll isn't there (either in this repo or in the npm module).

tiagoroldao avatar Oct 24 '17 17:10 tiagoroldao

What is the problem with merging this? It fixes a pretty critical bug, in my opinion.

tomca32 avatar Jan 31 '18 18:01 tomca32