Gabe Johnson

Results 127 comments of Gabe Johnson

I think this might be related to #569.

I checked some of these out and a few are fixed. Here's what's still broken: ```javascript // PARSING ERRORS: let hi = ( /* line-break */ ) => {} //...

This isn't as straightforward as it appears. The the shift-to-estree converter has to be updated to match the current versions of both the shift and estree specs. Then you'd have...

@disnet I updated shift-spidermonkey-converter to convert the current version of Shift to the current version of Esprima. I've also made a branch that converts to Babel instead https://github.com/gabejohnson/shift-spidermonkey-converter-js/tree/babel Tried it...

@disnet, I've done some preliminary benchmarking (added a simple script) and there does appear to be a modest performance increase for files < 100KB. That's when the babel `compact` option...

I think you have a bug in your definition of `$$`. It should be ```js operator $$ prefix 1 = (_, right) => { return #`...${right}`; }; ```

@capitalknew Sorry, I haven't had coffee yet. Your definition of `$$` was correct. I'll take a look in the editor.

> This is not coffee script I know. I was talking about the drink 😄 I think this issue is related to on https://github.com/sweet-js/sweet-core/pull/650#issuecomment-288863584. It's good to have an issue...

```js operator $ prefix 1 = (right) => { return #`${right}[0][${right}[1]]`; }; ``` is broken for a different reason. `right` is a `MacroContext` object an can't be interpolated the way...

So you're saying this should be tokenized as `foo$` and `{...}`? If so, I would find this behavior surprising as it is at odds w/ template literal syntax.