gabalafou
gabalafou
You've probably already thought through this, but just in case, I wanted to mention that in Chrome on my Mac, Command Shift A opens the **browser's** "Search Tabs" modal.
That [Jupyak build](https://jupyak--16.org.readthedocs.build/en/16/_static/work/lite/lab/) works great for testing this PR together with Lumino PR #655, thanks for that! I have two concerns with this PR: 1. Merging is delicate because of...
So, after giving this some thought, I think the best way to move forward with this PR is to just add role=button to the div that serves as the close...
@e218736 when you get a chance could you weigh in on these changes and my comments? If it looks good to you, I will approve this PR and merge it...
please update galata snapshots
Were the key bindings in commit f8d3aa18f34f2d68623ab2cf541ee936f420aab2 intentionally removed? I don't see how this PR is supposed to do what it advertises without those bindings in place
I appreciate people looking into this. I would like to make a number of points to hopefully get us all on the same page. ### The current state of things...
> user may need to distinguish between checkbox being focused and the item being focused. Nope, no need to distinguish so long as we make sure that the space bar...
I created an issue about the file browser checkboxes and assigned myself https://github.com/jupyterlab/jupyterlab/issues/15819
> The guidelines you link to specifically allows for use of hue+lightness though Right. I wasn't clear but I was referring specifically to your mockups and even more specifically to...