gaaclarke

Everything has been verified to work in https://github.com/flutter/engine/pull/52005 The skia gold bot is running on engine release branches and the produced golden tests have the release name appended to them.

I'm going to mark this as closed. I'm convinced we are good.

## workaround I found that resizing the web browser window will sometimes allow you to get the popup behavior if you are getting the "navigate to builders" behavior.

There already is code here to render the checkerboard ( https://github.com/flutter/engine/blob/f56c20c6ac674ceb571c06ce420749626a7d1e73/impeller/entity/entity_pass.cc#L1013 ) the `EntityPass::SetEnableOffscreenCheckerboard` method isn't getting called though.

There is a test for rendering the checkerboard ( `CanRenderOffscreenCheckerboard` ): https://flutter-engine-gold.skia.org/search?corpus=flutter-engine&include_ignored=false&left_filter=name%3Dimpeller_Play_AiksTest_CanRenderOffscreenCheckerboard_Metal&max_rgba=0&min_rgba=0&negative=true&not_at_head=false&positive=true&reference_image_required=false&right_filter=&sort=descending&untriaged=true It doesn't appear to render correctly despite the flag being correctly set and I can see it attempting...

> @Hixie recently removed the entry points to this in #147663 and [flutter/engine#52446](https://github.com/flutter/engine/pull/52446). So, this issue can probably be closed? Yea, if that's the case we can close this. @bytebai920...

Notes from chat: > Is something supposed to be clamping the results of this add operation to the [0, 1] range? Everything is in extended srgb when wide gamut is...

Here is the texture: here is the resolve: Neither the source or the destination are negative numbers, but the results are. I suspect the problem is more likely related to...

the gputrace: [PlusBlend.gputrace.zip](https://github.com/flutter/flutter/files/14609318/PlusBlend.gputrace.zip)

Found the fix, the blend mode for the alpha was wrong: ```diff --- a/impeller/entity/contents/content_context.cc +++ b/impeller/entity/contents/content_context.cc @@ -124,7 +124,7 @@ void ContentContextOptions::ApplyToPipelineDescriptor( color0.src_color_blend_factor = BlendFactor::kOneMinusDestinationAlpha; break; case BlendMode::kPlus: - color0.dst_alpha_blend_factor...