gaaclarke
gaaclarke
I've audited the time spent performing this copy of data in customer money's prototype app on iOS at startup as well. There were 20 instances of the copy called with...
@chinmaygarde friendly ping. This is caught up on your feedback. I responded to it with some options to move forward. Can you please capture where your head is at now....
Rebased to help @jiahaog's testing.
Update: The Dart team believes they may have a way to present a const bytebuffer with little runtime performance. Previously they thought the cost to reading and writing would make...
The unmodifiable bytes change for Dart has landed: https://github.com/dart-lang/sdk/commit/c1e67ac84f7d862aee14bbb9ce09346cef21dfa0 I haven't had a chance to hook it up. This looks like we can make it a non-breaking change compile-wise since...
@jason-simmons Can you please have a look at this draft PR? No need to approve it. I just want to make sure we are on a happy path. This PR...
Thanks @jason-simmons for taking a look. > I'm concerned that allowing access to the root isolate's `PlatformConfiguration` from multiple threads and isolates will be too confusing and error-prone. Likewise for...
Thanks, some clarifications and potential alternatives: > Before this the PlatformConfiguration was only accessed from the UI thread and from the root isolate. With this PR, other threads and isolates...
@dnfield I've responded to all the early feedback (thanks everyone) and have added tests and documentation, let's do this for real now. I also cut the scope to iOS in...
This in its current state actually breaks android platform channels of size 1 byte in the framework integration test here: https://github.com/gaaclarke/flutter/blob/2c22cd79a206503396dd31dc02074ccb66604259/dev/integration_tests/channels/lib/main.dart#L114:L114 That same test passes in iOS after the patch...