gaaclarke
gaaclarke
Depending how we address it, it might also resolve https://github.com/flutter/flutter/issues/152887. It's worth checking that issue if this one gets closed.
I pulled out the gaussian distribution to a texture that we sample. If anything it is slightly slower: https://github.com/flutter/engine/commit/54b76064bac26a778c432b929cf06dd3bc2e8453 I was hoping that since we are capturing an `exp` and...
After https://github.com/flutter/engine/pull/55604 rrect blurs are about 60% faster than they were before https://github.com/flutter/engine/pull/55576. Skia with our benchmark is at 2.5ms, where we are at 4.45ms. So skia is still faster,...
I looked a bit closer at what skia does. They have a separate path for circle blur and the rrect blur. For the circle blur they just create a 1d...
> What is the performance gain of specializing the rrect shader on this app? (i.e. if you just hack in the change for length) If we stick with the squircle...
> I now have a reduced test case in a playground that does reproduce the issue @chinmaygarde do you have the playground test somewhere?
> > I now have a reduced test case in a playground that does reproduce the issue > > @chinmaygarde do you have the playground test somewhere? Nevermind, it was...
I think this is a good way to quantify the problem. I've done a RMSE test that scales down the text, does a save layer and scales it back up....
It seems Skia provides a mechanism for developers to decide if they want pixel aligned glyphs or not, it's called hinting (see https://forum.vvvv.org/t/letters-jumping-in-skia-text-animation/16776). That's where most of the jiggling is...
This breaks an old golden test that is relying on a fixed 250 limit for the blur radius. But it is rendered at a content scalar of 1x so the...